feat(ebpf): configurable pipeline channel size #4182
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
geyslan
approved these changes
Jul 10, 2024
yanivagman
reviewed
Jul 11, 2024
cmd/tracee/cmd/root.go
Outdated
| 10000, | ||
| "<size>\t\t\t\tSize, in event objects, of each pipeline stage's output channel", | ||
| ) | ||
| err = viper.BindPFlag("blob-perf-buffer-size", rootCmd.Flags().Lookup("blob-perf-buffer-size")) |
There was a problem hiding this comment.
blob-perf-buffer-size? shouldn't this be pipeline-channel-size?
There was a problem hiding this comment.
It should be.
Allow configuring the event channels in pipeline stages using the `pipeline-channel-size` flag and config entry. Rigorous testing of the effect of playing with this value has yet to be done, so the default value is currently 10000 as hardcoded before. Tentatitevely, reducing the size of this configuration value may help reduce the mean memory usage, perhaps reduce channel contention, but may be at the cost of a greater risk for event loss.
NDStrahilevitz
force-pushed
the
pipeline_size_config
branch
from
236d33e to
f3d7bfc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
1. Explain what the PR does
236d33e feat(ebpf): configurable pipeline channel size
236d33e feat(ebpf): configurable pipeline channel size
2. Explain how to test it
tracee --pipeline-channel-size Xpipeline-channel-size: Xat the root level3. Other comments