-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add name attribute to application scope #270
Add name attribute to application scope #270
Conversation
Hi @Toqn, I've run the tests against your branch and there are some failures. The ones related to the Saas user resource are unrelated and will be fixed in #274 so don't worry about those. But it does appear your changes have failures for the application scope resource. I'm aware this PR has been open for a long time now and just letting you know, we haven't forgotten about it. I have recently taken on a maintainer role for the terraform provider here at Aqua so will be working on implementing these changes and will keep you updated. I don't expect you to do anything to fix these issues. Cheers |
As we've added a new variable to the application scope, we need to reference this variable in the expression to make it a valid request.
OK sorry for the noise. This should be good to go as soon as #274 gets merged, we can then merge those changes into your branch to get a fully passing test suite. Will have these additions in the next release of the aquasec provider. |
fixes #269