Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add name attribute to application scope #270

Merged

Conversation

Toqn
Copy link
Contributor

@Toqn Toqn commented Jul 18, 2024

fixes #269

@ehardisty
Copy link
Collaborator

Hi @Toqn,

I've run the tests against your branch and there are some failures. The ones related to the Saas user resource are unrelated and will be fixed in #274 so don't worry about those. But it does appear your changes have failures for the application scope resource.

I'm aware this PR has been open for a long time now and just letting you know, we haven't forgotten about it. I have recently taken on a maintainer role for the terraform provider here at Aqua so will be working on implementing these changes and will keep you updated. I don't expect you to do anything to fix these issues.

Cheers
Emerson

As we've added a new variable to the application scope, we need to reference this variable in the expression to make it a valid request.
@ehardisty
Copy link
Collaborator

OK sorry for the noise. This should be good to go as soon as #274 gets merged, we can then merge those changes into your branch to get a fully passing test suite. Will have these additions in the next release of the aquasec provider.

@ehardisty ehardisty merged commit b9f836a into aquasecurity:main Sep 23, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Using image labels in aqua_application_scopes does not work due to missing name attribute
3 participants