perf: Optimize cache by minimizing unnecessary data storage. #1406
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ug fixes, and memory optimization. Stripped managed fields and last-applied-configuration from resources and cache: Implemented object metadata transformation using `WithTransform` in `NewSharedInformerFactoryWithOptions` for shared informers. ref: informers package - k8s.io/client-go/informers - Go Packages Updated the controller runtime manager cache to include `DefaultTransform`, leveraging `TransformStripManagedFields()` along with logic to remove the last-applied-configuration annotation for all cached objects. ref: cache package - sigs.k8s.io/controller-runtime/pkg/cache - Go Packages These changes ensure that unwanted metadata is removed from objects before they are stored in the cache, optimizing memory usage and improving performance.
deven0t
approved these changes
Dec 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates to controller-runtime and client-go for better performance, b…ug fixes, and memory optimization.
Stripped managed fields and last-applied-configuration from resources and cache:
Implemented object metadata transformation using
WithTransforminNewSharedInformerFactoryWithOptionsfor shared informers. ref: informers package - k8s.io/client-go/informers - Go PackagesUpdated the controller runtime manager cache to include
DefaultTransform, leveragingTransformStripManagedFields()along with logic to remove the last-applied-configuration annotation for all cached objects. ref: cache package - sigs.k8s.io/controller-runtime/pkg/cache - Go PackagesThese changes ensure that unwanted metadata is removed from objects before they are stored in the cache, optimizing memory usage and improving performance.
Description
Related issues
Remove this section if you don't have related PRs.
Checklist