Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update GoReleaser to v1.23.0 to support windows/arm64 #1391

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

suzuki-shunsuke
Copy link

@suzuki-shunsuke suzuki-shunsuke commented Feb 5, 2024

Description

Resolve the following warning.

https://github.com/aquasecurity/starboard/actions/runs/7774726668/job/21199969973#step:8:30

      • DEPRECATED: skipped windows/arm64 build on Go < 1.17 for compatibility, check https://goreleaser.com/deprecations/#builds-for-windowsarm64 for more info.

https://goreleaser.com/deprecations/#builds-for-windowsarm64

Related issues

Remove this section if you don't have related PRs.

Checklist

  • I've read the guidelines for contributing to this repository.
  • I've added tests that prove my fix is effective or that my feature works.
  • I've updated the documentation with the relevant information (if needed).
  • I've added usage information (if the PR introduces new options)
  • I've included a "before" and "after" example to the description (if the PR is a user interface change).

@CLAassistant
Copy link

CLAassistant commented Feb 5, 2024

CLA assistant check
All committers have signed the CLA.

@suzuki-shunsuke
Copy link
Author

suzuki-shunsuke commented Feb 5, 2024

Test

I ran GoReleaser on my laptop.

$ goreleaser -v     
  ____       ____      _
 / ___| ___ |  _ \ ___| | ___  __ _ ___  ___ _ __
| |  _ / _ \| |_) / _ \ |/ _ \/ _` / __|/ _ \ '__|
| |_| | (_) |  _ <  __/ |  __/ (_| \__ \  __/ |
 \____|\___/|_| \_\___|_|\___|\__,_|___/\___|_|
goreleaser: Deliver Go Binaries as fast and easily as possible
https://goreleaser.com

GitVersion:    1.23.0
GitCommit:     3ec68fbf8c3a1b16ca0f69aeccfb93765685b643
GitTreeState:  false
BuildDate:     2023-12-26T14:29:46Z
BuiltBy:       goreleaser
GoVersion:     go1.21.5
Compiler:      gc
ModuleSum:     h1:QobII7SSYWboSNQO7sCOjKr5NjKZN+f41IMtseI1yKs=
Platform:      darwin/arm64
$ goreleaser release --clean --snapshot --skip docker
  • starting release...
  • loading                                          path=.goreleaser.yaml
  • skipping announce, docker, publish and validate...
  • loading environment variables
  • getting and validating git state
    • git state                                      commit=b5e1185b90f0c28150121879e295490ed27c44d0 branch=chore-update-goreleaser-to-1230 current_tag=v0.15.20 previous_tag=v0.15.19 dirty=true
    • pipe skipped                                   reason=disabled during snapshot mode
  • parsing tag
  • setting defaults
  • snapshotting
    • building snapshot...                           version=b5e1185b90f0c28150121879e295490ed27c44d0
  • running before hooks
    • running                                        hook=go mod download
  • checking distribution directory
    • cleaning dist
  • loading go mod information
  • build prerequisites
  • writing effective config file
    • writing                                        config=dist/config.yaml
  • building binaries
    • building                                       binary=dist/starboard-operator_linux_s390x/starboard-operator
    • building                                       binary=dist/starboard-operator_linux_arm_7/starboard-operator
    • building                                       binary=dist/starboard_darwin_amd64_v1/starboard
    • building                                       binary=dist/starboard_windows_amd64_v1/starboard.exe
    • building                                       binary=dist/starboard-operator_linux_arm64/starboard-operator
    • building                                       binary=dist/starboard_darwin_arm64/starboard
    • building                                       binary=dist/starboard_windows_arm64/starboard.exe
    • building                                       binary=dist/starboard_linux_amd64_v1/starboard
    • building                                       binary=dist/starboard_linux_arm64/starboard
    • building                                       binary=dist/starboard_linux_arm_7/starboard
    • building                                       binary=dist/starboard_windows_arm_7/starboard.exe
    • building                                       binary=dist/starboard-operator_linux_amd64_v1/starboard-operator
    • building                                       binary=dist/starboard-operator_linux_ppc64le/starboard-operator
    • building                                       binary=dist/starboard-operator-fips_linux_amd64_v1/starboard-operator-fips
    • building                                       binary=dist/starboard-operator-fips_linux_arm_7/starboard-operator-fips
    • building                                       binary=dist/starboard-operator-fips_linux_arm64/starboard-operator-fips
    • building                                       binary=dist/starboard-operator-fips_linux_s390x/starboard-operator-fips
    • building                                       binary=dist/starboard-operator-fips_linux_ppc64le/starboard-operator-fips
    • building                                       binary=dist/starboard-scanner-aqua_linux_amd64_v1/starboard-scanner-aqua
    • building                                       binary=dist/starboard-scanner-aqua_linux_arm_7/starboard-scanner-aqua
    • building                                       binary=dist/starboard-scanner-aqua_linux_arm64/starboard-scanner-aqua
    • took: 8s
  • archives
    • creating                                       archive=dist/starboard_darwin_x86_64.tar.gz
    • creating                                       archive=dist/starboard_linux_ARM64.tar.gz
    • creating                                       archive=dist/starboard_linux_ARM.tar.gz
    • creating                                       archive=dist/starboard_linux_x86_64.tar.gz
    • creating                                       archive=dist/starboard_windows_x86_64.zip
    • creating                                       archive=dist/starboard_windows_ARM.zip
    • creating                                       archive=dist/starboard_windows_ARM64.zip
    • creating                                       archive=dist/starboard_darwin_ARM64.tar.gz
    • took: 4s
  • calculating checksums
  • storing release metadata
    • writing                                        file=dist/artifacts.json
    • writing                                        file=dist/metadata.json
  • release succeeded after 12s
  • thanks for using goreleaser!

The warning was resolved.
starboard_windows_ARM64.zip was built properly.

$ ls dist 
artifacts.json                          starboard-operator_linux_amd64_v1      starboard_darwin_amd64_v1       starboard_windows_ARM.zip
checksums.txt                           starboard-operator_linux_arm64         starboard_darwin_arm64          starboard_windows_ARM64.zip
config.yaml                             starboard-operator_linux_arm_7         starboard_darwin_x86_64.tar.gz  starboard_windows_amd64_v1
metadata.json                           starboard-operator_linux_ppc64le       starboard_linux_ARM.tar.gz      starboard_windows_arm64
starboard-operator-fips_linux_amd64_v1  starboard-operator_linux_s390x         starboard_linux_ARM64.tar.gz    starboard_windows_arm_7
starboard-operator-fips_linux_arm64     starboard-scanner-aqua_linux_amd64_v1  starboard_linux_amd64_v1        starboard_windows_x86_64.zip
starboard-operator-fips_linux_arm_7     starboard-scanner-aqua_linux_arm64     starboard_linux_arm64
starboard-operator-fips_linux_ppc64le   starboard-scanner-aqua_linux_arm_7     starboard_linux_arm_7
starboard-operator-fips_linux_s390x     starboard_darwin_ARM64.tar.gz          starboard_linux_x86_64.tar.gz

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The pre-built binary for Windows ARM64 wasn't released at v0.15.20
2 participants