Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: cis-1.9 Kubernetes policies 5.1.6 audit script #1655

Merged
merged 3 commits into from
Oct 1, 2024
Merged

fix: cis-1.9 Kubernetes policies 5.1.6 audit script #1655

merged 3 commits into from
Oct 1, 2024

Conversation

winkrs
Copy link
Contributor

@winkrs winkrs commented Aug 5, 2024

Issue #1654

This PR is to update CIS 1.9 kubernetes policies 5.1.6 audit script to work when run inside a pod.

@CLAassistant
Copy link

CLAassistant commented Aug 5, 2024 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@mozillazg
Copy link
Collaborator

mozillazg commented Aug 6, 2024 •
edited
Loading

@andypitcher Could you help review these changes? Thanks!

andypitcher
andypitcher approved these changes Aug 9, 2024
View reviewed changes
Copy link
Contributor

@andypitcher andypitcher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, tested the changes in Fedora (bash), the expected check result is equivalent.

mozillazg
mozillazg approved these changes Aug 10, 2024
View reviewed changes
Copy link
Collaborator

@mozillazg mozillazg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Thanks for your contribution!

@mozillazg mozillazg requested a review from chen-keinan August 10, 2024 02:19
@mozillazg mozillazg requested review from afdesk and removed request for chen-keinan September 28, 2024 07:27
afdesk
afdesk approved these changes Oct 1, 2024
View reviewed changes
Copy link
Collaborator

@afdesk afdesk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for the contribution!

@afdesk afdesk merged commit 7ea1d59 into aquasecurity:main Oct 1, 2024
5 checks passed
@afdesk afdesk mentioned this pull request Oct 1, 2024
Closed
deebhatia pushed a commit to VoerEirAB/kube-bench that referenced this pull request Oct 14, 2024
@winkrs @deebhatia
update audit script for cis-1.9 kubernetes policies id 5.1.6 (aquasec…
d7519e3 
…urity#1655)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@afdesk afdesk afdesk approved these changes

@andypitcher andypitcher andypitcher approved these changes

@dereknola dereknola dereknola approved these changes

@mozillazg mozillazg mozillazg approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@winkrs @CLAassistant @mozillazg @dereknola @andypitcher @afdesk