feat(pom): add support of line numbers for deps from base pom.xml #287
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DmitriyLewen
commented
Jan 23, 2024
| @@ -409,7 +433,7 @@ func (p *parser) mergeDependencies(parent, child []artifact, exclusions map[stri | |||
| var deps []artifact | |||
| unique := map[string]struct{}{} | |||
|
|
|||
| for _, d := range append(parent, child...) { | |||
| for _, d := range append(child, parent...) { | |||
There was a problem hiding this comment.
go-dep-parser/pkg/java/pom/parse.go
Lines 325 to 328 in c95688d
Looks like it was a mistake.
I've updated test to show this:
https://github.com/aquasecurity/go-dep-parser/pull/287/files#diff-54393967b4dbd54d8dab7c5bf81ff4297c6fb825ff2bbf1805a4fdabec231146R44
knqyf263
reviewed
Jan 24, 2024
There was a problem hiding this comment.
How about this approach?
https://go.dev/play/p/YYQZyFgD9Vt?v=
|
It works! |
knqyf263
reviewed
Jan 24, 2024
Signed-off-by: knqyf263 <[email protected]>
Signed-off-by: knqyf263 <[email protected]>
|
@DmitriyLewen I refactored a bit so that we don't need to set nil to |
DmitriyLewen
commented
Jan 24, 2024
|
It looks good to me now. |
knqyf263
approved these changes
Jan 24, 2024
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add support of line numbers for deps from base pom.xml.
This PR doesn't add line numbers for:
Related issues