-
Notifications
You must be signed in to change notification settings - Fork 110
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
adding packages.props and Directory.packages.props parser #268
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello @yuriShafet
Thanks for work!
I left comments. Take a look, when you have time, please.
UPD:
1 more question - Can I use local packages? How does NuGet add them?
Co-authored-by: DmitriyLewen <[email protected]>
Co-authored-by: DmitriyLewen <[email protected]>
@DmitriyLewen I pushed updated version. Please resolve conversations that you think is resolved done and add more comments if necessary. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello @yuriShafet
Left comments.
Did you check local packages (#268 (review))?
pkg/nuget/packages_props/parse.go
Outdated
return &Parser{} | ||
} | ||
|
||
func (p *Parser) addPackage(libs* []types.Library, pkg propsPackageEntry) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry, I didn't think about that when I wrote this comment:
What if we just use Library
name?
func library(pkg entry) types.Library {
You mean packages that located in some local folder and nuget is configured to look into the folder or projects in same solution? Also, I pushed changes that should resolve your comments. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unfortunately, GitHub doesn’t allow me to make changes to your PR (maybe it is because you are using main
branch)
I left a few changes
Check that they don't break anything and merge them please
Co-authored-by: DmitriyLewen <[email protected]>
Co-authored-by: DmitriyLewen <[email protected]>
Co-authored-by: DmitriyLewen <[email protected]>
I merged your changes and pushed the updated version. Thanks for the comments. |
Co-authored-by: DmitriyLewen <[email protected]>
@DmitriyLewen |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@yuriShafet Great! Thanks!
PR looks good to me now.
Thanks for your work and sorry that i had to ask you to make all small changes.
To add options for maintainers to update your PR - it is better to create new PRs in a different branch (not the main).
@knqyf263 I approved this PR. Can you take a look, when you have time.
@DmitriyLewen I trust you 👍 |
@yuriShafet Can you create PR for Trivy now? |
@DmitriyLewen Will Do. Thanks |
No description provided.