feat: implement Julia parser #219
Conversation
|
@knqyf263 This is RTM from my end |
|
@knqyf263 Do I need to do anything else on this PR? |
|
@DmitriyLewen Can you please take a look first? |
There was a problem hiding this comment.
Hello @Octogonapus
Thanks for your work!
I left some comments.
Take a look, please.
|
Thank you for looking at this. Review comments have been addressed. |
| err = metadata.PrimitiveDecode(dep.Dependencies, &possibleDepsMap) | ||
| if err == nil { | ||
| possibleUuids := maps.Values(possibleDepsMap) | ||
| dep.DependsOn = possibleUuids |
There was a problem hiding this comment.
If i remember correctly - maps.Values returns values in random order. Can you add sort here?
There was a problem hiding this comment.
Thank you for this work!
Now this PR seems good to me.
@knqyf263 can you take a look and merge this PR, if it is okay for you?
|
@DmitriyLewen @knqyf263 bump |
|
@knqyf263 @DmitriyLewen bump, what else is needed for merge? |
|
Hello @Octogonapus @knqyf263 has some priority tasks. |
|
We've not seen any demand for this feature so far. Once this PR gets merged, maintainers need to keep maintaining. We probably want to suspend this task until the community needs it. |
|
@knqyf263 I understand. In the meantime, I asked the Julia community if others wanted this feature. They have added their support to aquasecurity/trivy#4437 |
OK, so let's merge your PR! But as we're not so familiar with Julia, we probably need support from the community. |
|
Hello @Octogonapus |
|
Thank you!
Yes I can help maintain this.
Yes I will. |
This PR implements parsing for Julia Manifests.
I'm adding this as part of aquasecurity/trivy#4438