feat: Rego engine QoL improvements #960
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
owenrumney
approved these changes
Sep 27, 2022
simar7
reviewed
Sep 28, 2022
Comment on lines
-1
to
-15
| package lib.result | ||
|
|
||
| new(msg, cause) = result { | ||
| metadata := object.get(cause, "__defsec_metadata", cause) | ||
| result := { | ||
| "msg": msg, | ||
| "startline": object.get(metadata, "startline", object.get(metadata, "StartLine", 0)), | ||
| "endline": object.get(metadata, "endline", object.get(metadata, "EndLine", 0)), | ||
| "filepath": object.get(metadata, "filepath", object.get(metadata, "Path", "")), | ||
| "explicit": object.get(metadata, "explicit", false), | ||
| "managed": object.get(metadata, "managed", true), | ||
| "fskey": object.get(metadata, "fskey", ""), | ||
| "resource": object.get(metadata, "resource", ""), | ||
| } | ||
| } |
There was a problem hiding this comment.
sorry just stumbled my way here – will this helper live somewhere else? (Maybe it already does and I might have missed it)
Today there are references to this in other policies such as https://github.com/aquasecurity/defsec/blob/master/internal/rules/docker/policies/add_instead_of_copy.rego#L36
We probably also need to update the policies with the correct import of wherever this helper would end up living as today they don't seem to have them.
I ran into this while importing all defsec rules into trivy through the OCI artifact.
docker/policies/add_instead_of_copy.rego:36: rego_type_error: undefined function result.new
There was a problem hiding this comment.
So this now works without the import as the function is provided as an extension via the Go library - it is now defined in Go.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #951