Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: load rego embedded libs by default #926

Merged
merged 4 commits into from
Sep 13, 2022
Merged

feat: load rego embedded libs by default #926

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
4e3b924
feat: load k8s embedded lib
chen-keinan Sep 6, 2022
6e36038
feat: load k8s embedded lib by default
chen-keinan Sep 6, 2022
8b3ffb4
feat: load k8s embedded lib by default
chen-keinan Sep 6, 2022
92585fc
feat: load k8s embedded lib by default
chen-keinan Sep 6, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 8 additions & 8 deletions pkg/rego/load.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -88,16 +88,16 @@ func (s *Scanner) LoadPolicies(loadEmbedded bool, srcFS fs.FS, paths []string, r
s.debug.Log("Overriding filesystem for policies!")
srcFS = s.policyFS
}
loadedLibs, errLoad := loadEmbeddedLibraries()
if errLoad != nil {
return fmt.Errorf("failed to load embedded rego libraries: %w", errLoad)
}
for name, policy := range loadedLibs {
s.policies[name] = policy
}
s.debug.Log("Loaded %d embedded libraries.", len(loadedLibs))

if loadEmbedded {
loadedLibs, err := loadEmbeddedLibraries()
if err != nil {
return fmt.Errorf("failed to load embedded rego libraries: %w", err)
}
for name, policy := range loadedLibs {
s.policies[name] = policy
}
s.debug.Log("Loaded %d embedded libraries.", len(loadedLibs))
loaded, err := loadEmbeddedPolicies()
if err != nil {
return fmt.Errorf("failed to load embedded rego policies: %w", err)
Expand Down
177 changes: 0 additions & 177 deletions pkg/scanners/kubernetes/scanner_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,183 +31,6 @@ spec:
- command: ["sh", "-c", "echo 'Hello' && sleep 1h"]
image: busybox
name: hello
`,
"/rules/lib.k8s.rego": `
package lib.kubernetes

default is_gatekeeper = false

is_gatekeeper {
has_field(input, "review")
has_field(input.review, "object")
}

object = input {
not is_gatekeeper
}

object = input.review.object {
is_gatekeeper
}

format(msg) = gatekeeper_format {
is_gatekeeper
gatekeeper_format = {"msg": msg}
}

format(msg) = msg {
not is_gatekeeper
}

name = object.metadata.name

default namespace = "default"

namespace = object.metadata.namespace

#annotations = object.metadata.annotations

kind = object.kind

is_pod {
kind = "Pod"
}

is_cronjob {
kind = "CronJob"
}

default is_controller = false

is_controller {
kind = "Deployment"
}

is_controller {
kind = "StatefulSet"
}

is_controller {
kind = "DaemonSet"
}

is_controller {
kind = "ReplicaSet"
}

is_controller {
kind = "ReplicationController"
}

is_controller {
kind = "Job"
}

split_image(image) = [image, "latest"] {
not contains(image, ":")
}

split_image(image) = [image_name, tag] {
[image_name, tag] = split(image, ":")
}

pod_containers(pod) = all_containers {
keys = {"containers", "initContainers"}
all_containers = [c | keys[k]; c = pod.spec[k][_]]
}

containers[container] {
pods[pod]
all_containers = pod_containers(pod)
container = all_containers[_]
}

containers[container] {
all_containers = pod_containers(object)
container = all_containers[_]
}

pods[pod] {
is_pod
pod = object
}

pods[pod] {
is_controller
pod = object.spec.template
}

pods[pod] {
is_cronjob
pod = object.spec.jobTemplate.spec.template
}

volumes[volume] {
pods[pod]
volume = pod.spec.volumes[_]
}

dropped_capability(container, cap) {
container.securityContext.capabilities.drop[_] == cap
}

added_capability(container, cap) {
container.securityContext.capabilities.add[_] == cap
}

has_field(obj, field) {
obj[field]
}

no_read_only_filesystem(c) {
not has_field(c, "securityContext")
}

no_read_only_filesystem(c) {
has_field(c, "securityContext")
not has_field(c.securityContext, "readOnlyRootFilesystem")
}

priviledge_escalation_allowed(c) {
not has_field(c, "securityContext")
}

priviledge_escalation_allowed(c) {
has_field(c, "securityContext")
has_field(c.securityContext, "allowPrivilegeEscalation")
}

annotations[annotation] {
pods[pod]
annotation = pod.metadata.annotations
}

host_ipcs[host_ipc] {
pods[pod]
host_ipc = pod.spec.hostIPC
}

host_networks[host_network] {
pods[pod]
host_network = pod.spec.hostNetwork
}

host_pids[host_pid] {
pods[pod]
host_pid = pod.spec.hostPID
}

host_aliases[host_alias] {
pods[pod]
host_alias = pod.spec
}
`,
"/rules/lib.util.rego": `
package lib.utils

has_key(x, k) {
_ = x[k]
}
`,
"/rules/rule.rego": `
package builtin.kubernetes.KSV011
Expand Down
177 changes: 0 additions & 177 deletions pkg/scanners/rbac/scanner_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,183 +34,6 @@ rules:
- secrets
verbs:
- list
`,
"/rules/lib.k8s.rego": `
package lib.kubernetes

default is_gatekeeper = false

is_gatekeeper {
has_field(input, "review")
has_field(input.review, "object")
}

object = input {
not is_gatekeeper
}

object = input.review.object {
is_gatekeeper
}

format(msg) = gatekeeper_format {
is_gatekeeper
gatekeeper_format = {"msg": msg}
}

format(msg) = msg {
not is_gatekeeper
}

name = object.metadata.name

default namespace = "default"

namespace = object.metadata.namespace

#annotations = object.metadata.annotations

kind = object.kind

is_pod {
kind = "Pod"
}

is_cronjob {
kind = "CronJob"
}

default is_controller = false

is_controller {
kind = "Deployment"
}

is_controller {
kind = "StatefulSet"
}

is_controller {
kind = "DaemonSet"
}

is_controller {
kind = "ReplicaSet"
}

is_controller {
kind = "ReplicationController"
}

is_controller {
kind = "Job"
}

split_image(image) = [image, "latest"] {
not contains(image, ":")
}

split_image(image) = [image_name, tag] {
[image_name, tag] = split(image, ":")
}

pod_containers(pod) = all_containers {
keys = {"containers", "initContainers"}
all_containers = [c | keys[k]; c = pod.spec[k][_]]
}

containers[container] {
pods[pod]
all_containers = pod_containers(pod)
container = all_containers[_]
}

containers[container] {
all_containers = pod_containers(object)
container = all_containers[_]
}

pods[pod] {
is_pod
pod = object
}

pods[pod] {
is_controller
pod = object.spec.template
}

pods[pod] {
is_cronjob
pod = object.spec.jobTemplate.spec.template
}

volumes[volume] {
pods[pod]
volume = pod.spec.volumes[_]
}

dropped_capability(container, cap) {
container.securityContext.capabilities.drop[_] == cap
}

added_capability(container, cap) {
container.securityContext.capabilities.add[_] == cap
}

has_field(obj, field) {
obj[field]
}

no_read_only_filesystem(c) {
not has_field(c, "securityContext")
}

no_read_only_filesystem(c) {
has_field(c, "securityContext")
not has_field(c.securityContext, "readOnlyRootFilesystem")
}

priviledge_escalation_allowed(c) {
not has_field(c, "securityContext")
}

priviledge_escalation_allowed(c) {
has_field(c, "securityContext")
has_field(c.securityContext, "allowPrivilegeEscalation")
}

annotations[annotation] {
pods[pod]
annotation = pod.metadata.annotations
}

host_ipcs[host_ipc] {
pods[pod]
host_ipc = pod.spec.hostIPC
}

host_networks[host_network] {
pods[pod]
host_network = pod.spec.hostNetwork
}

host_pids[host_pid] {
pods[pod]
host_pid = pod.spec.hostPID
}

host_aliases[host_alias] {
pods[pod]
host_alias = pod.spec
}
`,
"/rules/lib.util.rego": `
package lib.utils

has_key(x, k) {
_ = x[k]
}
`,
"/rules/rule.rego": `
package builtin.kubernetes.KSV041
Expand Down
Loading