Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(cloud): add availability zone filed for rds cluster #1424

Merged
merged 3 commits into from
Aug 18, 2023

Conversation

int-tt
Copy link
Contributor

@int-tt int-tt commented Aug 12, 2023

There is a behavior in availability_zones in aws_rds_cluster that may cause resource re-creation to be performed. An additional parameter has been added to allow inspection of this issue.

https://registry.terraform.io/providers/hashicorp/aws/latest/docs/resources/rds_cluster#availability_zones

@int-tt int-tt requested a review from simar7 as a code owner August 12, 2023 11:45
@knqyf263
Copy link
Contributor

🤠

Copy link
Member

@simar7 simar7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a couple of comments.

internal/adapters/cloudformation/aws/rds/cluster.go Outdated Show resolved Hide resolved
internal/adapters/terraform/aws/rds/adapt.go Outdated Show resolved Hide resolved
@simar7 simar7 force-pushed the feature/rds-cluser-az branch from e597e59 to 3c4f91c Compare August 18, 2023 05:30
@simar7 simar7 force-pushed the feature/rds-cluser-az branch from 3c4f91c to a51ab0b Compare August 18, 2023 05:54
@simar7 simar7 self-requested a review August 18, 2023 06:16
@simar7 simar7 added this pull request to the merge queue Aug 18, 2023
Merged via the queue into aquasecurity:master with commit 063dcd6 Aug 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants