Improve the command splitting #1326
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tspearconquest
changed the title
|
is there a case where the existing implementation fails? |
|
I can't think of any off the top of my head other than if someone has a typo like ls /usr/bin&& ls /root where the space is missing before or after the && which would cause a failure to build the image anyway since it's not proper shell syntax.
That said, the old way does not match the spaces and could result in the spaces finding their way into commands_list, which probably isn't intended.
|
…mmand_cd_instead_of_workdir.rego Signed-off-by: Thomas Spear <[email protected]>
simar7
approved these changes
May 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This matches the split used in
run_command_cd_instead_of_workdir.rego