feat(terraform) adding trivy:ignore for tf scans to align with trivy #1188
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simar7
reviewed
Feb 20, 2023
Comment on lines
+69
to
+86
| func Test_TrivyOptionWithAlternativeIDProvider(t *testing.T) { | ||
| reg := rules.Register(alwaysFailRule, nil) | ||
| defer rules.Deregister(reg) | ||
|
|
||
| options := []options.ScannerOption{ | ||
| ScannerWithAlternativeIDProvider(func(s string) []string { | ||
| return []string{"something", "altid", "blah"} | ||
| }), | ||
| } | ||
| results := scanWithOptions(t, ` | ||
| //trivy:ignore:altid | ||
| resource "something" "else" {} | ||
| `, options...) | ||
| require.Len(t, results.GetFailed(), 0) | ||
| require.Len(t, results.GetIgnored(), 1) | ||
|
|
||
| } | ||
|
|
There was a problem hiding this comment.
As most of the other inputs are the same, can we make this into a table driven test instead? So something like:
testCases := []struct{
name string
inputOptions string}{
{ name: "tfsec", inputOptions: "..."}}
then you can iterate over them as inputs:
for _, tc := range testCases {
t.Run(...)
}
simar7
reviewed
Feb 20, 2023
test/trivy_ignore_test.go
Outdated
| @@ -0,0 +1,393 @@ | |||
| package test | |||
There was a problem hiding this comment.
Likewise with this file as well. ignore_test.go could include all the ignores, trivy and tfsec as test inputs for each of the existing tests within ignore_test.go.
simar7
reviewed
Feb 20, 2023
|
@simar7 I made the changes we discussed. please review and merge if all looks good |
simar7
force-pushed
the
feature/adding-trivy-ignore-for-tf-files
branch
from
076100f to
46ad24d
Compare
simar7
approved these changes
Feb 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Aligning with trivy to allow inline ignores using trivy:ignore.