feat: add compliance spec for nsa #1021
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: chenk <[email protected]>
chen-keinan
force-pushed
the
feat/add-compliance-nsa-spec
branch
from
9b07126 to
030e2dd
Compare
Signed-off-by: chenk <[email protected]>
chen-keinan
force-pushed
the
feat/add-compliance-nsa-spec
branch
from
030e2dd to
43abc86
Compare
liamg
approved these changes
Oct 19, 2022
owenrumney
approved these changes
Oct 19, 2022
simar7
reviewed
Nov 2, 2022
| @@ -0,0 +1,175 @@ | |||
| --- | |||
There was a problem hiding this comment.
For my understanding, how was this spec created? Is it available somewhere as a yaml file or you just translated their PDF into this yaml?
Would you know if they have similar spec for AWS?
There was a problem hiding this comment.
I have created it my self bases on investigation of the NSA spec and made the relevant mapping to rego
simar7
reviewed
Nov 3, 2022
| description: 'Control check whether audit policy is configure' | ||
| id: '8.0' | ||
| defaultStatus: 'FAIL' | ||
| checks: |
There was a problem hiding this comment.
Another quick q: why some of these checks don't have an associated rule (check)? Is it because we don't support it?
There was a problem hiding this comment.
Yes , see #1042 ,we now tag it as Manual checks. Trivy can't run these checks in a non intrusive mode (outside of the cluster) .but it still part of Nsa so we added it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: chenk [email protected]
Description:
Add compliance spec for nsa
Close: #1022