return if already absPath

Signed-off-by: Simar <[email protected]>

pkg/scanners/terraform/parser/load_vars.go

@@ -14,8 +14,8 @@ import (
 	"github.com/zclconf/go-cty/cty"
 )
 
-func getAbsPath(path string) (string, error) {
-	p, err := filepath.Abs(path)
+func getAbsPath(inputPath string) (string, error) {
+	p, err := filepath.Abs(inputPath)
 	if err != nil {
 		return "", fmt.Errorf("unable to determine path: %w", err)
 	}
@@ -71,6 +71,7 @@ func loadTFVarsFile(srcFS fs.FS, filename string) (map[string]cty.Value, error)
 	if err != nil {
 		return nil, err
 	}
+	absPath = filepath.ToSlash(absPath) // in memory fs is only slash based
 
 	src, err := fs.ReadFile(srcFS, absPath)
 	if err != nil {

pkg/scanners/terraform/parser/load_vars_test.go

@@ -3,27 +3,22 @@ package parser
 import (
 	"testing"
 
+	"github.com/zclconf/go-cty/cty"
+
 	"github.com/aquasecurity/defsec/pkg/extrafs"
 	"github.com/stretchr/testify/assert"
 	"github.com/stretchr/testify/require"
-	"github.com/zclconf/go-cty/cty"
 )
 
 func Test_TFVarsFile(t *testing.T) {
 	t.Run("tfvars file", func(t *testing.T) {
-		absPath, err := getAbsPath("testdata/tfvars/terraform.tfvars")
-		require.NoError(t, err)
-
-		vars, err := loadTFVars(extrafs.OSDir("/"), []string{absPath})
+		vars, err := loadTFVars(extrafs.OSDir("/"), []string{"testdata/tfvars/terraform.tfvars"})
 		require.NoError(t, err)
 		assert.Equal(t, "t2.large", vars["instance_type"].AsString())
 	})
 
 	t.Run("tfvars json file", func(t *testing.T) {
-		absPath, err := getAbsPath("testdata/tfvars/terraform.tfvars.json")
-		require.NoError(t, err)
-
-		vars, err := loadTFVars(extrafs.OSDir("/"), []string{absPath})
+		vars, err := loadTFVars(extrafs.OSDir("/"), []string{"testdata/tfvars/terraform.tfvars.json"})
 		require.NoError(t, err)
 		assert.Equal(t, "bar", vars["variable"].GetAttr("foo").GetAttr("default").AsString())
 		assert.Equal(t, "qux", vars["variable"].GetAttr("baz").AsString())