fix(selectors): Evaluate policy when no selectors are present

Signed-off-by: Simar <[email protected]>

pkg/rego/scanner.go

@@ -285,10 +285,6 @@ func isPolicyWithSubtype(sourceType types.Source) bool {
 }
 
 func checkSubtype(ii map[string]interface{}, provider string, subTypes []SubType) bool {
-	if len(subTypes) == 0 { // policy always applies if no subtypes
-		return true
-	}
-
 	for _, st := range subTypes {
 		switch services := ii[provider].(type) {
 		case map[string]interface{}: // cloud
@@ -318,6 +314,10 @@ func isPolicyApplicable(staticMetadata *StaticMetadata, inputs ...Input) bool {
 					continue
 				}
 
+				if len(staticMetadata.InputOptions.Selectors) == 0 { // policy always applies if no selectors
+					return true
+				}
+
 				// check metadata for subtype
 				for _, s := range staticMetadata.InputOptions.Selectors {
 					if checkSubtype(ii, provider, s.Subtypes) {

pkg/scanners/cloud/aws/scanner_test.go

@@ -105,7 +105,7 @@ deny[res] {
 			expectedResults: struct {
 				totalResults int
 				summaries    []string
-			}{totalResults: 0},
+			}{totalResults: 2, summaries: []string{"RDS Publicly Accessible", "CloudTrail Bucket Delete Policy"}},
 		},
 		{
 			name: "selector is empty",
@@ -146,7 +146,7 @@ deny[res] {
 			expectedResults: struct {
 				totalResults int
 				summaries    []string
-			}{totalResults: 0},
+			}{totalResults: 2, summaries: []string{"RDS Publicly Accessible", "CloudTrail Bucket Delete Policy"}},
 		},
 		{
 			name: "selector without subtype",