[txns] Fix navigation in transactions with back #965
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kaw2k
requested changes
Jan 6, 2025
src/pages/Transactions/Index.tsx
Outdated
Comment on lines
18
to
28
| useEffect(() => { | ||
| if (userTxnOnly) { | ||
| if (isGraphqlClientSupported && !searchParams.get("type")) { | ||
| searchParams.set("type", "user"); | ||
| return setSearchParams(searchParams, {replace: true}); | ||
| } | ||
|
|
||
| if (!isGraphqlClientSupported && !searchParams.get("type")) { | ||
| searchParams.set("type", "all"); | ||
| return setSearchParams(searchParams, {replace: true}); | ||
| } | ||
| }, [isGraphqlClientSupported, searchParams, setSearchParams, allTxnOnly]); |
There was a problem hiding this comment.
Just a touch of cleanup here:
- Looks like we no longer need
allTxnOnlyso we can omit it from the dependency array - You should only return a cleanup function from
useEffect, otherwise, avoid returns.
I suggest the following:
useEffect(() => {
if (!searchParams.get("type")) {
searchParams.set("type", isGraphqlClientSupported ? "user" : "all");
setSearchParams(searchParams, { replace: true });
}
}, [isGraphqlClientSupported, searchParams, setSearchParams]);There was a problem hiding this comment.
Looks correct and simpler, added changes to pull request
Thank you for review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello!
Fix back navigation in transactions page
For the first navigation to transactions, a replacement is used so that you can exit with one click
Navigations between user and all transactions work as usual
Before:
Screen.Recording.2024-12-20.at.12.24.25.mov
After
Screen.Recording.2024-12-20.at.12.39.39.mov
Thanks!