Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Retain order for property maps #668

Merged
merged 1 commit into from
Jan 14, 2025
Merged

Retain order for property maps #668

merged 1 commit into from
Jan 14, 2025

Conversation

CapCap
Copy link
Contributor

@CapCap CapCap commented Jan 14, 2025

Ensure that the property maps from tokens maintain their order, to prevent deltas between different versions due to different keys (but with same data)

@CapCap CapCap requested a review from a team January 14, 2025 19:52
@just-in-chang
Copy link
Contributor

Wonder if BTreeMap would be better here? It'd make the order even more deterministic (ord trait instead of just insertion order)

Copy link

codecov bot commented Jan 14, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 48.9%. Comparing base (27d9d66) to head (f071f48).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##            main    #668     +/-   ##
=======================================
- Coverage   48.9%   48.9%   -0.1%     
=======================================
  Files        233     233             
  Lines      27301   27301             
=======================================
- Hits       13366   13358      -8     
- Misses     13935   13943      +8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@larry-aptos
Copy link
Collaborator

Wonder if BTreeMap would be better here? It'd make the order even more deterministic (ord trait instead of just insertion order)

I assume we want to preserve the ordering from PropertyMap; for BTreeMap, we need to define the ordering for each key

@CapCap CapCap merged commit a905292 into main Jan 14, 2025
11 checks passed
@CapCap CapCap deleted the max_ordered_property_maps branch January 14, 2025 20:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants