Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix parquet token datas none data handling #649

Merged
merged 1 commit into from
Dec 17, 2024

Conversation

yuunlimm
Copy link
Contributor

@yuunlimm yuunlimm commented Dec 17, 2024

Description

The None data wasn't properly handled for TokenDataV2 model.

  • updated parquet models to handle None values to have None, not the default String.
Screenshot 2024-12-16 at 4 42 19 PM

Test Plan

ran a processor for 10 mins with no issues.
Screenshot 2024-12-16 at 4 43 12 PM

Copy link
Contributor Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

@yuunlimm yuunlimm marked this pull request as ready for review December 17, 2024 00:44
Copy link

codecov bot commented Dec 17, 2024

Codecov Report

Attention: Patch coverage is 32.63158% with 64 lines in your changes missing coverage. Please review.

Project coverage is 48.2%. Comparing base (c094090) to head (8fcb021).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...b/parquet/models/token_v2_models/v2_token_datas.rs 0.0% 15 Missing ⚠️
.../src/db/parquet/models/ans_models/ans_lookup_v2.rs 0.0% 12 Missing ⚠️
...b/parquet/models/ans_models/ans_primary_name_v2.rs 0.0% 12 Missing ⚠️
rust/processor/src/processors/ans_processor.rs 0.0% 7 Missing ⚠️
.../postgres/models/ans_models/ans_primary_name_v2.rs 50.0% 6 Missing ⚠️
...arquet/models/token_v2_models/v2_token_metadata.rs 0.0% 4 Missing ⚠️
...eps/parquet_ans_processor/parquet_ans_extractor.rs 0.0% 4 Missing ⚠️
...set_models/parquet_v2_fungible_asset_activities.rs 0.0% 2 Missing ⚠️
rust/processor/src/processors/default_processor.rs 0.0% 1 Missing ⚠️
...uet_default_processor/parquet_default_extractor.rs 0.0% 1 Missing ⚠️
Additional details and impacted files
@@          Coverage Diff          @@
##            main    #649   +/-   ##
=====================================
  Coverage   48.2%   48.2%           
=====================================
  Files        229     229           
  Lines      27016   27015    -1     
=====================================
  Hits       13029   13029           
+ Misses     13987   13986    -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@yuunlimm yuunlimm force-pushed the 12-16-fix_parquet_token_datas_none_data_handling branch from 1569bed to 8fcb021 Compare December 17, 2024 21:20
@yuunlimm yuunlimm merged commit 1973e8b into main Dec 17, 2024
11 checks passed
@yuunlimm yuunlimm deleted the 12-16-fix_parquet_token_datas_none_data_handling branch December 17, 2024 22:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants