-
Notifications
You must be signed in to change notification settings - Fork 79
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix token claims #627
fix token claims #627
Conversation
0da8dc2
to
f9cba7c
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #627 +/- ##
=======================================
+ Coverage 49.2% 49.3% +0.1%
=======================================
Files 195 195
Lines 25665 25701 +36
=======================================
+ Hits 12629 12678 +49
+ Misses 13036 13023 -13 ☔ View full report in Codecov by Sentry. |
f9cba7c
to
8b2f096
Compare
1921fd3
to
323b0b1
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
code lgtm. can you explain the testing screenshot please? i don't understand how it tests the new logic
@dermanyang token v2 processor is failing in devnet with version 19922017 so to test the fix, I ran it with the fix locally and checked that 1) the processor didn't panic and 2) the data is correct. also added an integration test for this case. |
Description
When a token gets claimed, processor needs to know the previous owner for token_activities_v2. Currently the processor gets it from PendingClaimsResource but in this case the resource wasn't found in the transaction and breaks the processor. This PR tries to get it previous owner from the TokenClaim event instead of the table metadata.
Testing