Add Monitoring and User Transaction Processors #597
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dermanyang
changed the title
rtso
approved these changes
Nov 8, 2024
Comment on lines
41
to
70
| let mut signatures = vec![]; | ||
| let mut user_transactions = vec![]; | ||
| for txn in item.data { | ||
| let txn_version = txn.version as i64; | ||
| let block_height = txn.block_height as i64; | ||
| let txn_data = match txn.txn_data.as_ref() { | ||
| Some(txn_data) => txn_data, | ||
| None => { | ||
| PROCESSOR_UNKNOWN_TYPE_COUNT | ||
| .with_label_values(&["UserTransactionProcessor"]) | ||
| .inc(); | ||
| tracing::warn!( | ||
| transaction_version = txn_version, | ||
| "Transaction data doesn't exist" | ||
| ); | ||
| continue; | ||
| }, | ||
| }; | ||
| if let TxnData::User(inner) = txn_data { | ||
| let (user_transaction, sigs) = UserTransactionModel::from_transaction( | ||
| inner, | ||
| txn.timestamp.as_ref().unwrap(), | ||
| block_height, | ||
| txn.epoch as i64, | ||
| txn_version, | ||
| ); | ||
| signatures.extend(sigs); | ||
| user_transactions.push(user_transaction); | ||
| } | ||
| } |
There was a problem hiding this comment.
we haven't been doing this for the other processors, but could we move this into a shared function to improve maintainability? someone could come in and edit the parsing logic for non-SDK processor and forget to also update the SDK processor.
There was a problem hiding this comment.
ah good shout. added
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Add User Transaction Processor
Add Monitoring Processor
Its just the transaction stream since the processor just no-ops