Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Speed up tests by avoiding long lookups #596

Merged
merged 1 commit into from
Nov 7, 2024
Merged

Speed up tests by avoiding long lookups #596

merged 1 commit into from
Nov 7, 2024

Conversation

rtso
Copy link
Collaborator

@rtso rtso commented Nov 7, 2024

Description

Single transaction test should not need to lookup any data in the DB since it won't exist anyway. Lower the lookup retries and wait time to speed up the test.

Testing

Before

test sdk_tests::stake_processor_tests::tests::mainnet_stake_gov_record_txn has been running for over 60 seconds
test sdk_tests::stake_processor_tests::tests::mainnet_stake_pool_delegation_txn has been running for over 60 seconds

After
cargo test runs fine

@rtso rtso changed the title avoid doing long lookups Speed up tests by avoiding long lookups Nov 7, 2024
Copy link
Collaborator Author

rtso commented Nov 7, 2024

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @rtso and the rest of your teammates on Graphite Graphite

@rtso rtso marked this pull request as ready for review November 7, 2024 20:23
@rtso rtso requested review from dermanyang and yuunlimm November 7, 2024 20:23
@rtso rtso merged commit aad75a4 into main Nov 7, 2024
7 checks passed
Copy link
Collaborator Author

rtso commented Nov 7, 2024

Merge activity

  • Nov 7, 3:38 PM EST: A user merged this pull request with Graphite.

@rtso rtso deleted the 11-07-avoid_lookups branch November 7, 2024 20:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants