Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add objects tests #590

Merged
merged 3 commits into from
Nov 6, 2024
Merged

Add objects tests #590

merged 3 commits into from
Nov 6, 2024

Conversation

rtso
Copy link
Collaborator

@rtso rtso commented Nov 6, 2024 •
edited
Loading

Description

Before

Screenshot 2024-11-05 at 8.15.14 PM.png

After

Screenshot 2024-11-05 at 8.39.31 PM.png

Testing

current_objects

Screenshot 2024-11-05 at 8.12.11 PM.png

Screenshot 2024-11-05 at 8.12.08 PM.png

objects

Has same number of rows

Screenshot 2024-11-05 at 8.11.43 PM.png

Screenshot 2024-11-05 at 8.11.27 PM.png

@rtso rtso changed the title objects tests Add objects tests Nov 6, 2024
@rtso Graphite App
Copy link
Collaborator Author

rtso commented Nov 6, 2024

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @rtso and the rest of your teammates on Graphite Graphite

@rtso rtso requested review from dermanyang and yuunlimm November 6, 2024 01:15
@rtso rtso marked this pull request as ready for review November 6, 2024 01:15
@rtso rtso merged commit 9ae249c into main Nov 6, 2024
7 checks passed
@rtso rtso deleted the 11-05-objects_tests branch November 6, 2024 16:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dermanyang dermanyang dermanyang approved these changes

@yuunlimm yuunlimm Awaiting requested review from yuunlimm

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rtso @dermanyang