Add Default Processor Tests for table_items, current_table_items, and block_metadata_transactions #577
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dermanyang
changed the title
dermanyang
commented
Oct 31, 2024
| // serde_json::to_value(&cti_result)?, | ||
| // ); | ||
|
|
||
| // TODO: revisit we need to find out a way to find correct table metadata |
There was a problem hiding this comment.
@yuunlimm do we still need this table metadata? It's not part of the default processor?
There was a problem hiding this comment.
The create_table_item event, which generates table_metadata for a table_item, is part of the default processor. To test this, we need to identify the correct transaction version containing the create_table_item event, as table_metadata records doesn't have a transaction_version field. For the test case, we should either pull all rows to verify the presence of the expected data since filtering by transaction version isn’t an option for us here
rtso
approved these changes
Nov 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
as above
Coverage Improvemenet
Old Coverage Stats:
New Coverage Stats:
Test Verification
Current Table Items
Table Items
BMT