Rewrite Stake Processor with SDK #576
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rtso
reviewed
Oct 29, 2024
Comment on lines
+78
to
+82
| let per_table_chunk_sizes: AHashMap<String, usize> = self | ||
| .processor_config | ||
| .default_config | ||
| .per_table_chunk_sizes | ||
| .clone(); |
There was a problem hiding this comment.
Now that I think about it, I think we should move this part to the processor so we avoid the clone every time process is called?
rtso
reviewed
Oct 29, 2024
rtso
approved these changes
Oct 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
parse_stake_data.Testing