Documentation for FA processor #546
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This stack of pull requests is managed by Graphite. Learn more about stacking. |
bowenyang007
reviewed
Oct 9, 2024
| @@ -394,6 +394,7 @@ impl FungibleAssetBalance { | |||
| last_transaction_timestamp: txn_timestamp, | |||
| token_standard: TokenStandard::V1.to_string(), | |||
| }; | |||
| // What is this for? | |||
There was a problem hiding this comment.
V1 events don't have asset type. It's just "0x1::coin::WithdrawEvent" (or something like that) w/ the address and amount of APT.
There was a problem hiding this comment.
Ok I see you've commented about it in the main file so I'll leave this.
bowenyang007
approved these changes
Oct 9, 2024
|
Dev docs post migration makes sense to me. |
rtso
force-pushed
the
10-08-documentation
branch
from
92bbf80 to
7c21f9f
Compare
Merge activity
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.