Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow cross repo workflow trigger (#526) #528

Merged
merged 4 commits into from
Oct 1, 2024

Conversation

yuunlimm
Copy link
Contributor

@yuunlimm yuunlimm commented Oct 1, 2024

description

this is to allow aptos-core repo to trigger processor intregration test to support a case where json files are updated in aptos-core, we pass in commit hash along with the event, and it updates dependency using toml-cli.

Test Plan

PR level test pass: https://github.com/aptos-labs/aptos-indexer-processors/actions/runs/11131978344
dispatch passed: https://github.com/aptos-labs/aptos-indexer-processors/actions/runs/11131969466

@yuunlimm yuunlimm force-pushed the yuunlimm/repo-dispatch-integ-test branch from 1c23de8 to 4114893 Compare October 1, 2024 17:38
@yuunlimm yuunlimm force-pushed the yuunlimm/repo-dispatch-integ-test branch 18 times, most recently from 9b2fba9 to 7ba971d Compare October 1, 2024 18:51
@yuunlimm yuunlimm force-pushed the yuunlimm/repo-dispatch-integ-test branch from 7ba971d to ea61c58 Compare October 1, 2024 18:54
@yuunlimm yuunlimm marked this pull request as ready for review October 1, 2024 19:33
@yuunlimm yuunlimm requested review from larry-aptos and a team October 1, 2024 19:35
@@ -1,25 +1,59 @@
name: Run Integration Tests

on:
repository_dispatch:
types: [json-change-detected] # Custom event type to trigger the workflow
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: is it possible to make this more specific?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

how specific are you thinking? I think we can though, it's all custom

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe something like test-txn-json-change-detected?

.github/workflows/integration-tests.yaml Outdated Show resolved Hide resolved
.github/workflows/integration-tests.yaml Outdated Show resolved Hide resolved
@yuunlimm yuunlimm enabled auto-merge (squash) October 1, 2024 20:29
@yuunlimm yuunlimm merged commit 073fccf into main Oct 1, 2024
7 checks passed
@yuunlimm yuunlimm deleted the yuunlimm/repo-dispatch-integ-test branch October 1, 2024 20:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants