[patch] Fix bug where we're identifying v2 inserts wrong #523
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
larry-aptos
reviewed
Sep 25, 2024
| // by looking at whether asset_type_v1 is null (must be v1 if not null) | ||
| // by looking at whether asset_type_v2 is null (must be v1 if it's null) | ||
| // Note, we can't check asset_type_v1 is none because we're now filling asset_type_v1 | ||
| // for certain assets | ||
| current_unified_fungible_asset_balances | ||
| .into_iter() |
There was a problem hiding this comment.
@yuunlimm let's start adding this as the first test. ❤️
There was a problem hiding this comment.
@bowenyang007 what's the transaction version if any?
There was a problem hiding this comment.
yea this v1 and v2 thing is easy to miss.
There was a problem hiding this comment.
we might need custom transactions for this b/c idk if there's a single transaction on testnet or mainnet representative. or we can just write a script and deploy to testnet lol
There was a problem hiding this comment.
actually this one on mainnet should break if the logic is wrong: 1669115601
larry-aptos
approved these changes
Sep 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The previous migration logic introduced db conflicts where v2 inserts were identified as v1 because we're filling asset_type_v1. This fixes that.
previous PR: #519