Update the rust version and depdnecy #515
Conversation
larry-aptos
commented
Sep 18, 2024
•
larry-aptos
commented
- Update the dependency version and rust version to be compatible with aptos-core.
|
This stack of pull requests is managed by Graphite. Learn more about stacking. Join @larry-aptos and the rest of your teammates on |
larry-aptos
force-pushed
the
09-18-update_the_rust_version_and_depdnecy
branch
from
60c9701 to
d9dbdee
Compare
|
This stack of pull requests is managed by Graphite. Learn more about stacking. Join @larry-aptos and the rest of your teammates on |
larry-aptos
force-pushed
the
09-18-update_the_rust_version_and_depdnecy
branch
from
d9dbdee to
3a0e4de
Compare
|
This stack of pull requests is managed by Graphite. Learn more about stacking. Join @larry-aptos and the rest of your teammates on |
larry-aptos
force-pushed
the
09-18-update_the_rust_version_and_depdnecy
branch
from
3a0e4de to
bd12c63
Compare
| prost = { version = "0.12.3", features = ["no-recursion-limit"] } | ||
| prost-types = "0.12.3" | ||
| rayon = "1.10.0" | ||
| # Keep it compatible with the aptos-core version. | ||
| rayon = "1.5.2" |
There was a problem hiding this comment.
Hopefully nothing breaks with this change lol, 1.10 -> 1.5.2 seems like a big change
There was a problem hiding this comment.
this is the version aptos-core uses and here it's introduced by @grao1991
let me know if you have any concern. I feel upgrade rayon from 1.5.2 to 1.10 at aptos-core side is more aggressive 🤦
There was a problem hiding this comment.
Going to merge and we can revisit this if there is performance degradation.
larry-aptos
force-pushed
the
09-18-update_the_rust_version_and_depdnecy
branch
from
bd12c63 to
96e1ad7
Compare
