Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

clean up default processor #507

Merged
merged 5 commits into from
Sep 27, 2024
Merged

Conversation

yuunlimm
Copy link
Contributor

Description

We stopped writing some tables in default processor, this is to clean up the parsing logic and remove dead code.

Test Plan

Ran a processor locally against testnet and verified that the numbers of rows written for the remaining tables are same as ones from testnet. checked using the SDM.
Screenshot 2024-09-13 at 2 03 04 PM
Screenshot 2024-09-13 at 2 02 28 PM
Screenshot 2024-09-13 at 2 02 22 PM
Screenshot 2024-09-13 at 2 02 18 PM
Screenshot 2024-09-13 at 2 02 13 PM

@yuunlimm yuunlimm requested a review from a team September 14, 2024 00:01
Copy link
Collaborator

@bowenyang007 bowenyang007 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice nice thanks.

@yuunlimm yuunlimm force-pushed the yuunlimm/clean-up-default-processor branch 2 times, most recently from 71e9486 to 2cebb22 Compare September 17, 2024 23:49
@yuunlimm yuunlimm requested a review from a team September 17, 2024 23:49
@yuunlimm yuunlimm force-pushed the yuunlimm/clean-up-default-processor branch from 2cebb22 to 5ea8cb6 Compare September 18, 2024 21:13
@yuunlimm yuunlimm force-pushed the yuunlimm/clean-up-default-processor branch from 5ea8cb6 to 915bff4 Compare September 26, 2024 20:28
@yuunlimm yuunlimm merged commit 4213590 into main Sep 27, 2024
7 checks passed
@yuunlimm yuunlimm deleted the yuunlimm/clean-up-default-processor branch September 27, 2024 04:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants