Improve logging for indexer models and processors #505
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rtso
reviewed
Sep 13, 2024
rtso
reviewed
Sep 13, 2024
rust/processor/src/db/common/models/default_models/write_set_changes.rs
Outdated
Show resolved
Hide resolved
rtso
reviewed
Sep 13, 2024
rust/processor/src/db/common/models/default_models/write_set_changes.rs
Outdated
Show resolved
Hide resolved
dermanyang
changed the title
yuunlimm
approved these changes
Sep 16, 2024
dermanyang
deleted the
dermanyang/add_logging_for_unspecified_write_set_change
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Context for onboarding task
Additional metadata (
write_set_change_indexand/ortxn_version) to logs for easier debugging.Namely, logs in
coin_utils.rswrite_set_changes.rsans_processor.rsThe rest of the diff is just making the appropriate variables available for the logging.
Testing
Ran
default_processor(for wsc.unspecified logging),ans_processorandfungible_asset_processorlocally.