Fix current_aptos_names view #503
Merged
+90
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rtso
commented
Sep 10, 2024
| FROM current_ans_lookup_v2 cal | ||
| LEFT JOIN current_ans_primary_name_v2 capn ON cal.token_name = capn.token_name | ||
| AND cal.token_standard = capn.token_standard | ||
| AND capn.registered_address = cal.registered_address |
There was a problem hiding this comment.
This is the only line that changed.
There was a problem hiding this comment.
add a comment in the file that this is the only line that changed?
bowenyang007
approved these changes
Sep 13, 2024
rtso
force-pushed
the
rtso/ans-registered-addr
branch
from
1f31695 to
8c72460
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
There's a bug in the ANS contract where the primary name and the ANS don't point to the same registered address if a primary name token gets transfered. This caused the
current_aptos_namesview to show the wrong primary name because it joins only ontoken_name. We need to add a constraint to the left join oncurrent_ans_lookup_v2.registered_address = current_ans_primary_name_v2.registered_addressTesting
Run the SQL and see that is_primary = false
