Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

handle filtered events and make it null events when there are events … #476

Merged
merged 1 commit into from
Jul 30, 2024

Conversation

yuunlimm
Copy link
Contributor

@yuunlimm yuunlimm commented Jul 29, 2024

…size info

Description

backfilling parquet events processor was looping due to the failure of handling filtered events on testing txn: 1496685738
context: https://aptos-org.slack.com/archives/C03MN5F7WUV/p1721575481807169

so to avoid inconsistency, we are alined on handling in a way of inserting x "empty/null" rows for filtered events when there are x number of event size info.

Test Plan

Tested locally that it's handling all cases

  1. num of events = # of events_size_info
  2. num of events != # of events_size_info (events empty )
  3. num of events = # of events_size_info (events_size_info empty)
    Screenshot 2024-07-29 at 4 41 54 PM
    Screenshot 2024-07-29 at 4 42 16 PM

@yuunlimm yuunlimm requested a review from a team July 29, 2024 23:42
@yuunlimm yuunlimm force-pushed the yuunlimm/parquet-filtered-events branch from bb9617e to 8465ddf Compare July 29, 2024 23:44
Copy link
Contributor

@ying-w ying-w left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Public slack channel with context: https://aptos-org.slack.com/archives/C05QFF1RXB8/p1719351858150769

Events show up in JSON but not GRPC

grpcurl -d '{ "starting_version": 1496685738, "transactions_count": 1 }' -max-msg-sz 30000000 -H "authorization:Bearer xyz" grpc.testnet.aptoslabs.com:443 aptos.indexer.v1.RawData/GetTransactions

compared to https://fullnode.testnet.aptoslabs.com/v1/transactions/by_version/1496685738

we want to be consistent about excluding and counting as excluded

@yuunlimm
Copy link
Contributor Author

Screenshot 2024-07-30 at 3 31 22 PM
testnet working fine.

@yuunlimm yuunlimm merged commit b3875a3 into main Jul 30, 2024
7 checks passed
@yuunlimm yuunlimm deleted the yuunlimm/parquet-filtered-events branch July 30, 2024 22:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants