[EI-444] Migrate events processor to sdk #470
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rtso
commented
Jul 19, 2024
grao1991
reviewed
Jul 19, 2024
rtso
changed the title
grao1991
reviewed
Jul 30, 2024
grao1991
reviewed
Jul 30, 2024
|
|
||
| fn main() -> Result<()> { | ||
| let num_cpus = num_cpus::get(); | ||
| let worker_threads = (num_cpus * RUNTIME_WORKER_MULTIPLIER).max(16); |
There was a problem hiding this comment.
I understand this is copied from the current code, but I don't see any reason to do RUNTIME_WORKER_MULTIPLIER, or max(16) here.
There was a problem hiding this comment.
I think it's ok to use just num_cpus.
grao1991
reviewed
Jul 30, 2024
grao1991
reviewed
Jul 30, 2024
rtso
force-pushed
the
sdk-migration
branch
7 times, most recently
from
492ca77 to
af38d2c
Compare
rtso
force-pushed
the
sdk-migration
branch
2 times, most recently
from
be74c70 to
6c0e87a
Compare
grao1991
approved these changes
Aug 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Migrate the events processor to using aptos-indexer-processor-sdk. The plan is to deploy it and monitor performance.
Testing
Run events processor
