Indexer processor metrics improvements. #469
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
sitalkedia
commented
Jul 18, 2024
sitalkedia
commented
- Fix some latency counters for indexer processor
- Add batch size metrics
grao1991
approved these changes
Jul 23, 2024
rtso
reviewed
Jul 23, 2024
rust/processor/src/utils/counters.rs
Outdated
| @@ -147,6 +147,15 @@ pub static PROCESSED_BYTES_COUNT: Lazy<IntCounterVec> = Lazy::new(|| { | |||
| .unwrap() | |||
| }); | |||
|
|
|||
| pub static BATCH_SIZE: Lazy<HistogramVec> = Lazy::new(|| { | |||
There was a problem hiding this comment.
we already have a metric like this. it's NUM_TRANSACTIONS_PROCESSED_COUNT
There was a problem hiding this comment.
There is a slight semantic difference because this is batch_end-batch_start but for all practical purpose, this is good. Removed the counter for now.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.