-
Notifications
You must be signed in to change notification settings - Fork 79
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Validator API Fix]support validator txn with its events. #454
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Besides delegated staking activities, are there other staking models that need to be indexed? I'd imagine we also need to index the wsc of validator txn's
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
updated; all i did is for the places that requires match TxnData::
branching logic, I added Validator condition..
but for if TxnData::User
, I ignored them since they're usually specific to user transactions.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We need to parse all the wsc in ValidatorTransaction now, because there might be delegator resource changes in them. Like here:
aptos-indexer-processors/rust/processor/src/db/common/models/stake_models/delegator_pools.rs
Line 119 in 98386c6
if let TxnData::User(_) = txn_data { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
wait.. but this event was moved from BlockMetadtaTransaciton, does this mean we forgot to handle the writesetchanges in BlockMetadataTransaciton?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you have the proto txn? We can take a look at what's in it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you update the description with testnet and mainnet backfill versions? Which version did the first validator txn appear? |
Addressed the comments; ready for another review. |
6d18285
to
b9df927
Compare
978d3e8
to
73591d8
Compare
Description
Backfill
Test Plan
Tested in devnet and looks good.