Add tranche 2 default model to Parquet #450
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rtso
approved these changes
Jul 11, 2024
| @@ -185,13 +192,22 @@ impl Transaction { | |||
| #[allow(deprecated)] | |||
| let block_timestamp = chrono::NaiveDateTime::from_timestamp_opt(timestamp.seconds, 0) | |||
| .expect("Txn Timestamp is invalid!"); | |||
|
|
|||
| let txn_size_info = transaction.size_info.as_ref(); | |||
| let write_set_size_info: &Vec<WriteOpSizeInfo> = if let Some(size_info) = txn_size_info { | |||
There was a problem hiding this comment.
Suggested change
| let write_set_size_info: &Vec<WriteOpSizeInfo> = if let Some(size_info) = txn_size_info { | |
| let write_set_size_info = if let Some(size_info) = txn_size_info { |
| let write_set_size_info: &Vec<WriteOpSizeInfo> = if let Some(size_info) = txn_size_info { | ||
| size_info.write_op_size_info.as_ref() | ||
| } else { | ||
| &EMPTY_VEC |
There was a problem hiding this comment.
Could we use Vec::new() instead of static variable?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Test Plan
tested locally
txn_total_bytes column added to transaction table
table_items table
table_metadata table in testnet
write_set_size info added to write_ste_changes table
move_modules
