add property maps indexing to collections v2 #437
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rtso
reviewed
Jul 1, 2024
| @@ -0,0 +1,5 @@ | |||
| ALTER TABLE current_collections_v2 | |||
| DROP COLUMN collection_properties; | |||
|
Need to also update the insert query and backfill query. Could you specify the backfill versions for testnet and mainnet? It should be the first version that had a collection |
could you elaborate? @rtso |
rtso
reviewed
Jul 1, 2024
| @@ -354,6 +354,7 @@ fn insert_current_collections_v2_query( | |||
| table_handle_v1.eq(excluded(table_handle_v1)), | |||
| token_standard.eq(excluded(token_standard)), | |||
| last_transaction_version.eq(excluded(last_transaction_version)), | |||
| collection_properties.eq(excluded(collection_properties)), | |||
There was a problem hiding this comment.
You also need to update insert_collections_v2_query so that it backfills the new column
jillxuu
force-pushed
the
jill/add-collection-property-maps
branch
from
ca260c8 to
73cd024
Compare
jillxuu
force-pushed
the
jill/add-collection-property-maps
branch
from
73cd024 to
d2e1cea
Compare
yuunlimm
approved these changes
Jul 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
backfill:
testnet: 18589
mainnet: 169280