Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix a bug not returning entry function id for multisig #417

Merged
merged 1 commit into from
Jun 20, 2024

Conversation

yuunlimm
Copy link
Contributor

@yuunlimm yuunlimm commented Jun 20, 2024

bug: https://aptos-org.slack.com/archives/C03MN5F7WUV/p1718806535035359
we weren't returning the string in the match statement

Test plan
Screenshot 2024-06-20 at 2 59 32 PM
Screenshot 2024-06-20 at 2 59 28 PM

All processor call this get_entry_function_from_user_request function need to backfill:

  1. fungible_asset
  2. token_v2
  3. user_transaction
  4. coin_activities

the backfill versions are

  • mainnet: 2175935
  • testnet: 60849758

@yuunlimm yuunlimm requested a review from a team June 20, 2024 22:09
Copy link
Collaborator

@rtso rtso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice fix!

@yuunlimm yuunlimm merged commit cd96639 into main Jun 20, 2024
6 of 7 checks passed
@yuunlimm yuunlimm deleted the yuunlimm/bug-fix-multisig branch June 20, 2024 22:56
@alex4506
Copy link

Great job! And will you backfill the mainnet / testnet data?

@rtso
Copy link
Collaborator

rtso commented Jun 24, 2024

@mizu-flex yep we're gonna run the backfill for mainnet and testnet today!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants