[release][aip-83][1.13] Add untransferable handling for FA and token #405
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rtso
reviewed
Jun 13, 2024
rust/processor/src/db/common/models/fungible_asset_models/v2_fungible_asset_balances.rs
Outdated
Show resolved
Hide resolved
yuunlimm
reviewed
Jun 13, 2024
| @@ -31,6 +31,7 @@ pub struct Object { | |||
| pub guid_creation_num: BigDecimal, | |||
| pub allow_ungated_transfer: bool, | |||
| pub is_deleted: bool, | |||
| pub untransferrable: bool, | |||
There was a problem hiding this comment.
nit: typo -> untransferable
There was a problem hiding this comment.
actually neither is a word haha. i prefer 2 r's but idk 🤷
rtso
approved these changes
Jun 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Handling this AIP https://github.com/aptos-foundation/AIPs/blob/main/aips/aip-83.md
Basically if an object is created with Untransferable resource then it cannot be transferred by anyone including the creator/admin. This PR addresses 3 changes in the indexer
Note, we're not doing anything on the fungible asset front since is_frozen is not affected and there's nothing on store level transferrability currently.
Backfill
Not actually required if upgrading on time. Otherwise, need to upgrade objects_processor, and token_v2_processor
Testing
Obj: https://explorer.aptoslabs.com/txn/1231307643?network=testnet
Token: https://explorer.aptoslabs.com/txn/1231310601?network=testnet
