[EI-370] Timeout if grpc request takes too long #362
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rtso
changed the title
grao1991
approved these changes
May 2, 2024
just-in-chang
approved these changes
May 2, 2024
yuunlimm
approved these changes
May 2, 2024
yuunlimm
pushed a commit
that referenced
this pull request
May 9, 2024
* Timeout if grpc request takes too long * Add config var
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When updating grpc image, we observe some processor reconnection hangs when making the grpc request. Example where processor hangs for 2 mins (link).
This adds a 5s timeout to the grpc request. If it takes too long it will retry up to 5 times.
Testing
Restart 3/4 of the data service pods and monitor the processors reconnection
Before
Some processors taking > 1.5 min to reconnect
After
Processors that time out making the grpc request, try to reconnect faster. All processors reconnect faster
