Refactor the code to make it easier to support multiple db backends in the future. #350
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
grao1991
force-pushed
the
grao_features
branch
11 times, most recently
from
ca5227e to
5b26a4f
Compare
grao1991
force-pushed
the
grao_features
branch
2 times, most recently
from
1c28d39 to
1212282
Compare
bowenyang007
previously requested changes
Apr 22, 2024
grao1991
force-pushed
the
grao_features
branch
2 times, most recently
from
a286c76 to
2c60fe2
Compare
Tested and added one line in README. |
grao1991
force-pushed
the
grao_features
branch
2 times, most recently
from
80df6f9 to
b4b3b92
Compare
CapCap
approved these changes
Jun 11, 2024
CapCap
reviewed
Jun 11, 2024
rust/processor/src/db/common/mod.rs
Outdated
There was a problem hiding this comment.
The command should be run inside src/db/postgres/
CapCap
reviewed
Jun 11, 2024
rust/processor/src/db/mod.rs
Outdated
| @@ -0,0 +1 @@ | |||
| pub(crate) mod common; | |||
There was a problem hiding this comment.
pub again, no? otherwise how will SDK use any of this
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Restructure the directories.
Rename several variables to remove "Pg".
Remove some unused methods.
Tested on the local machine, verified both manually running migration and running migration through rust code can work.
Instructions
cdinto the database folder you use undersrc/db/(e.g.src/db/postgres), then run it.