Add ConcurrentFungibleAssetSupply and ConcurrentFungibleAssetBalance #338
Conversation
| @@ -112,7 +124,7 @@ impl FungibleAssetBalance { | |||
| asset_type: asset_type.clone(), | |||
| is_primary, | |||
| is_frozen: inner.frozen, | |||
| amount: inner.balance.clone(), | |||
| amount: concurrent_balance.unwrap_or_else(|| inner.balance.clone()), | |||
| let concurrent_balance: Option<BigDecimal> = | ||
| ConcurrentFungibleAssetBalance::from_write_resource( | ||
| write_resource, | ||
| txn_version, | ||
| ) | ||
| .ok() | ||
| .and_then(|balance| balance.map(|b| Some(b.balance.value.clone()))) | ||
| .unwrap_or(None); |
There was a problem hiding this comment.
wait how are you able to get the balance given this write resource is actually FungibleAssetStore? I think that you might need to pre-process and store it in object_metadatas
There was a problem hiding this comment.
Fixed it by pre-processing and storing in object_metadatas.
| pub current: AggregatorU128, | ||
| } | ||
|
|
||
| impl ConcurrentFungibleAssetSupply { |
There was a problem hiding this comment.
This doesn't seem to be used anywhere?
There was a problem hiding this comment.
Thanks for the observation. I am now pre-processing and storing the ConcurrentFungibleAssetSupply in object_metadatas. I modified FungibleAssetMetadataModel to store the ConcurrentFungibleAssetSupply in supply_v2 and maximum_v2.
|
Can you also add a test plan? Usually for testing, we run the processor on example transactions and check that the data stored in postgres is correct. |
vusirikala
force-pushed
the
satya/fungible-concurrenty-supply
branch
from
b9245ca to
60f48d6
Compare
|
Any progress? |
rust/processor/src/utils/util.rs
Outdated
| @@ -450,6 +450,15 @@ pub struct AggregatorSnapshotU64 { | |||
| pub value: BigDecimal, | |||
| } | |||
|
|
|||
| // TODO: How is this different from AgggregatorU64? | |||
| #[derive(Serialize, Deserialize, Debug, Clone)] | |||
| pub struct AggregatorU128 { | |||
There was a problem hiding this comment.
if it's not diff from U64 can you just rename and reuse? These names don't matter. E.g. you can name it AggregatorBigint or something.
bowenyang007
force-pushed
the
satya/fungible-concurrenty-supply
branch
2 times, most recently
from
bcaa820 to
5ba621c
Compare
bowenyang007
force-pushed
the
satya/fungible-concurrenty-supply
branch
from
5ba621c to
8b217d4
Compare
vusirikala
force-pushed
the
satya/fungible-concurrenty-supply
branch
from
8b217d4 to
d742c8b
Compare
This PR adds the indexer support for the AIP 70 (aptos-labs/aptos-core#11183).
AIP 70 adds ConcurrentSupply and ConcurrentBalance for fungible assets. Unlike the regular supply and balance, the newly added ConcurrentSupply and ConcurrentBalance use aggregators for improved parallelizability.
This PR indexes ConcurrentSupply and ConcurrentBalance in the indexer. The indexing is done in a way that Supply and ConcurrentSupply, Balance and ConcurrentBalance are treated identically when storing into the database so that the indexer client wouldn't notice a difference whether the aggregators are being used or not.
Backfill