Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change the config structure. #337

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Change the config structure. #337

wants to merge 1 commit into from

Conversation

grao1991
Copy link
Contributor

@grao1991 grao1991 commented Apr 2, 2024

Change the config to support various features, including:

  • running multiple processors together in a server
  • providing multiple db connection urls

etc.

Implementation will be provided in future PRs.

@grao1991 grao1991 marked this pull request as ready for review April 2, 2024 23:59
@grao1991 grao1991 requested review from CapCap and larry-aptos April 3, 2024 00:00
Copy link
Collaborator

@bowenyang007 bowenyang007 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wait why are we doing this? And what's the potential downside of having multiple services?

If this is for a particular test, can we make a custom processor for this? Instead of making this the new normal.

@grao1991
Copy link
Contributor Author

wait why are we doing this? And what's the potential downside of having multiple services?

If this is for a particular test, can we make a custom processor for this? Instead of making this the new normal.

There are people asking for this feature. It could save a lot of bandwidth and resource since multiple processor can share the same fetcher.

@grao1991 grao1991 requested a review from bowenyang007 April 16, 2024 20:38
Copy link
Collaborator

@bowenyang007 bowenyang007 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pushing back to your queue. This looks like it needs to be synced with the SDK workstream. Let's have online meetings about changes that affect the UX directly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants