Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Compatibility Check Workflow #335

Merged
merged 3 commits into from
Apr 2, 2024
Merged

Compatibility Check Workflow #335

merged 3 commits into from
Apr 2, 2024

Conversation

larry-aptos
Copy link
Collaborator

@larry-aptos larry-aptos commented Mar 27, 2024 •
edited
Loading

  • Goal: if new enum variant or oneof field is added, this check will break.
  • The data quality/correctness will be checked separately.

Testing Plan

When new enum variant or oneof field is added, workflow failure:

image

@larry-aptos larry-aptos force-pushed the check-external-protobuf-compatibility branch 2 times, most recently from 6b874e7 to feb7e80 Compare March 28, 2024 00:26
@larry-aptos larry-aptos changed the title Partial workflow. Compatibility Check Workflow Mar 28, 2024
@larry-aptos larry-aptos force-pushed the check-external-protobuf-compatibility branch from d73a7c3 to c568c5f Compare March 28, 2024 22:39
@larry-aptos larry-aptos force-pushed the check-external-protobuf-compatibility branch from c568c5f to f100d1d Compare March 28, 2024 22:40
@larry-aptos larry-aptos requested a review from a team March 28, 2024 22:44
yuunlimm
yuunlimm approved these changes Apr 2, 2024
View reviewed changes
Copy link
Contributor

@yuunlimm yuunlimm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good!

@larry-aptos larry-aptos merged commit 31d9564 into main Apr 2, 2024
8 checks passed
@larry-aptos larry-aptos deleted the check-external-protobuf-compatibility branch April 2, 2024 19:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yuunlimm yuunlimm yuunlimm approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@larry-aptos @yuunlimm