[rust] handle burn properly for partial burns #327
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bowenyang007
requested review from
CapCap,
just-in-chang,
yuunlimm and
larry-aptos
bowenyang007
force-pushed
the
fix_burn
branch
2 times, most recently
from
2c5b71a to
9065ddc
Compare
just-in-chang
approved these changes
Mar 21, 2024
| @@ -296,20 +339,19 @@ impl TokenOwnershipV2 { | |||
| query_retries: u32, | |||
| query_retry_delay_ms: u64, | |||
| ) -> anyhow::Result<Option<(Self, CurrentTokenOwnershipV2)>> { | |||
| let token_address = standardize_address(&write_resource.address.to_string()); | |||
| if let Some(burn_event) = tokens_burned.get(&token_address) { | |||
| if let Some(burn_event) = tokens_burned.get(token_address) { | |||
There was a problem hiding this comment.
Maybe call standardize_address() on tokens_burned here too in case we use the helper fn anywhere else in the future
There was a problem hiding this comment.
ok yea good poitn.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This closes the loop on the messy logic that is burning NFTs:
There could be a complete burn or a partial burn.
This PR fixes the partial burn case.
Backfill
First burn event
Testnet: 835574507
Mainnet: 151521169
Testing
NFT burnt!
