Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[hotfix] optimize checking if fungible token logic #320

Merged
merged 1 commit into from
Mar 10, 2024
Merged

[hotfix] optimize checking if fungible token logic #320

merged 1 commit into from
Mar 10, 2024

Conversation

bowenyang007
Copy link
Collaborator

No description provided.

rtso
rtso reviewed Mar 10, 2024
View reviewed changes
rust/processor/src/models/token_v2_models/v2_token_datas.rs
Ok(is_token) => is_token,
Err(e) => {
// TODO: Standardize this error handling
panic!("Version: {}, error {:?}", txn_version, e)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i thought we never want to have panics

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

look at the logic. this is db connection error.

@bowenyang007 bowenyang007 merged commit ff17f4a into aptos-indexer-processors-v1.10 Mar 10, 2024
4 checks passed
@bowenyang007 bowenyang007 deleted the fix_ft branch March 10, 2024 20:34
bowenyang007 added a commit that referenced this pull request Mar 21, 2024
@bowenyang007
optimize checking if fungible token logic (#320)
2358181
bowenyang007 added a commit that referenced this pull request Mar 21, 2024
@bowenyang007
Merge v1.10 into main (#328)
48d7794 
* optimize checking if fungible token logic (#320)

* [indexer] Make query retries and delay into parameters (#321)

* optimize checking if fungible token logic

* move query retries and query cooldown between retries to parameters

* do not wait if we're done retrying

* lint

* lint
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rtso rtso rtso approved these changes

@just-in-chang just-in-chang Awaiting requested review from just-in-chang

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bowenyang007 @rtso