Remove dependency on objects processor #311
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rtso
force-pushed
the
rtso/remove-objects-dependency
branch
from
a7b80d4 to
b47c7fe
Compare
bowenyang007
reviewed
Mar 8, 2024
Comment on lines
+4
to
+9
| ALTER TABLE objects | ||
| DROP COLUMN IF EXISTS is_fungible_asset, | ||
| DROP COLUMN IF EXISTS is_token; | ||
| ALTER TABLE current_objects | ||
| DROP COLUMN IF EXISTS is_fungible_asset, | ||
| DROP COLUMN IF EXISTS is_token; |
There was a problem hiding this comment.
do we need to remove these? Maybe we keep them?
There was a problem hiding this comment.
idk when someone would ever use this. they can just look at the fungible and token tables. and this is gonna change once we have a fungible token standard.
bowenyang007
approved these changes
Mar 8, 2024
rtso
added a commit
that referenced
this pull request
Mar 8, 2024
rtso
added a commit
that referenced
this pull request
Mar 8, 2024
rtso
added a commit
that referenced
this pull request
Mar 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
To improve dev ex, we remove the dependency of token v2 / fungible asset processor on objects processor.
In
fungible_asset_metadata, introduce a columnis_token_v2. Fungible asset processor will lookupis_token_v2to skip indexing fungible tokens.Token v2 processor will lookup
current_token_datas_v2.is_fungible_v2to index the fungible token.Test
Fungible token with metadata in same txn. https://explorer.aptoslabs.com/txn/351790067/userTxnOverview?network=mainnet
See that the fungible token is indexed in the tokens table and not the fungible balances table.
Normal fungible asset indexing still works
Normal token indexing still works
Objects indexing still works
