Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TS SDK] Clean up tests #9088

Merged
merged 1 commit into from
Jul 13, 2023
Merged

[TS SDK] Clean up tests #9088

merged 1 commit into from
Jul 13, 2023

Conversation

0xmaayan
Copy link
Contributor

@0xmaayan 0xmaayan commented Jul 13, 2023

Description

We can't really test this function now as we need to change the seed and then precompile the module to be published with the new resource account address before everytest, obviously this is not feasible when running ts sdk tests.
more context https://aptos-org.slack.com/archives/C03N9HNSUB1/p1689278043871009

Test Plan

Copy link
Contributor

@lightmark lightmark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:(

@0xmaayan 0xmaayan enabled auto-merge (squash) July 13, 2023 21:05
@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions
Copy link
Contributor

✅ Forge suite compat success on aptos-node-v1.5.1 ==> 1d2c3cf0573e16a9b968933a6fbe8a80b9adac73

Compatibility test results for aptos-node-v1.5.1 ==> 1d2c3cf0573e16a9b968933a6fbe8a80b9adac73 (PR)
1. Check liveness of validators at old version: aptos-node-v1.5.1
compatibility::simple-validator-upgrade::liveness-check : committed: 4711 txn/s, latency: 6532 ms, (p50: 6800 ms, p90: 8600 ms, p99: 10200 ms), latency samples: 183760
2. Upgrading first Validator to new version: 1d2c3cf0573e16a9b968933a6fbe8a80b9adac73
compatibility::simple-validator-upgrade::single-validator-upgrade : committed: 1845 txn/s, latency: 15499 ms, (p50: 19200 ms, p90: 21900 ms, p99: 22300 ms), latency samples: 92280
3. Upgrading rest of first batch to new version: 1d2c3cf0573e16a9b968933a6fbe8a80b9adac73
compatibility::simple-validator-upgrade::half-validator-upgrade : committed: 1820 txn/s, latency: 15935 ms, (p50: 18800 ms, p90: 22300 ms, p99: 22600 ms), latency samples: 92820
4. upgrading second batch to new version: 1d2c3cf0573e16a9b968933a6fbe8a80b9adac73
compatibility::simple-validator-upgrade::rest-validator-upgrade : committed: 4077 txn/s, latency: 7290 ms, (p50: 6900 ms, p90: 10500 ms, p99: 13800 ms), latency samples: 171260
5. check swarm health
Compatibility test for aptos-node-v1.5.1 ==> 1d2c3cf0573e16a9b968933a6fbe8a80b9adac73 passed
Test Ok

@github-actions
Copy link
Contributor

✅ Forge suite realistic_env_max_load success on 1d2c3cf0573e16a9b968933a6fbe8a80b9adac73

two traffics test: inner traffic : committed: 5504 txn/s, latency: 7062 ms, (p50: 6600 ms, p90: 8400 ms, p99: 17000 ms), latency samples: 2400080
two traffics test : committed: 100 txn/s, latency: 2937 ms, (p50: 2800 ms, p90: 3400 ms, p99: 8900 ms), latency samples: 1800
Max round gap was 1 [limit 4] at version 264946. Max no progress secs was 4.569542 [limit 10] at version 264946.
Test Ok

@github-actions
Copy link
Contributor

✅ Forge suite framework_upgrade success on aptos-node-v1.5.1 ==> 1d2c3cf0573e16a9b968933a6fbe8a80b9adac73

Compatibility test results for aptos-node-v1.5.1 ==> 1d2c3cf0573e16a9b968933a6fbe8a80b9adac73 (PR)
Upgrade the nodes to version: 1d2c3cf0573e16a9b968933a6fbe8a80b9adac73
framework_upgrade::framework-upgrade::full-framework-upgrade : committed: 4427 txn/s, latency: 7147 ms, (p50: 7500 ms, p90: 9500 ms, p99: 12500 ms), latency samples: 168240
5. check swarm health
Compatibility test for aptos-node-v1.5.1 ==> 1d2c3cf0573e16a9b968933a6fbe8a80b9adac73 passed
Test Ok

@0xmaayan 0xmaayan merged commit c1b4534 into main Jul 13, 2023
@0xmaayan 0xmaayan deleted the remove_test branch July 13, 2023 21:43
banool pushed a commit that referenced this pull request Jul 19, 2023
gedigi pushed a commit that referenced this pull request Aug 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants