Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[indexer grpc] mark protobuf schema stable; remove testing from its pkg path. #8277

Merged
merged 3 commits into from
May 18, 2023

Conversation

larry-aptos
Copy link
Contributor

@larry-aptos larry-aptos commented May 18, 2023

Description

🤖 Generated by Copilot at 87bf25c

No summary available (Limit exceeded: required to process 90928 tokens, but only 50000 are allowed per call)

Test Plan

Copy link

@ying-w ying-w left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remember to communicate out the removal of testing

@larry-aptos larry-aptos enabled auto-merge (squash) May 18, 2023 22:56
@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions
Copy link
Contributor

✅ Forge suite compat success on testnet_2d8b1b57553d869190f61df1aaf7f31a8fc19a7b ==> 87bf25c7a334caf8b93aa6412ce53021e284ee20

Compatibility test results for testnet_2d8b1b57553d869190f61df1aaf7f31a8fc19a7b ==> 87bf25c7a334caf8b93aa6412ce53021e284ee20 (PR)
1. Check liveness of validators at old version: testnet_2d8b1b57553d869190f61df1aaf7f31a8fc19a7b
compatibility::simple-validator-upgrade::liveness-check : 10351 TPS, 3648 ms latency, 6100 ms p99 latency,no expired txns
2. Upgrading first Validator to new version: 87bf25c7a334caf8b93aa6412ce53021e284ee20
compatibility::simple-validator-upgrade::single-validator-upgrade : 5878 TPS, 6785 ms latency, 8700 ms p99 latency,no expired txns
3. Upgrading rest of first batch to new version: 87bf25c7a334caf8b93aa6412ce53021e284ee20
compatibility::simple-validator-upgrade::half-validator-upgrade : 5710 TPS, 7032 ms latency, 10000 ms p99 latency,no expired txns
4. upgrading second batch to new version: 87bf25c7a334caf8b93aa6412ce53021e284ee20
compatibility::simple-validator-upgrade::rest-validator-upgrade : 1634 TPS, 31622 ms latency, 41000 ms p99 latency,no expired txns
5. check swarm health
Compatibility test for testnet_2d8b1b57553d869190f61df1aaf7f31a8fc19a7b ==> 87bf25c7a334caf8b93aa6412ce53021e284ee20 passed
Test Ok

@github-actions
Copy link
Contributor

✅ Forge suite land_blocking success on 87bf25c7a334caf8b93aa6412ce53021e284ee20

performance benchmark : 6239 TPS, 6333 ms latency, 25700 ms p99 latency,(!) expired 309 out of 2664780 txns
Test Ok

@github-actions
Copy link
Contributor

✅ Forge suite framework_upgrade success on aptos-node-v1.3.0_3fc3d42b6cfe27460004f9a0326451bcda840a60 ==> 87bf25c7a334caf8b93aa6412ce53021e284ee20

Compatibility test results for aptos-node-v1.3.0_3fc3d42b6cfe27460004f9a0326451bcda840a60 ==> 87bf25c7a334caf8b93aa6412ce53021e284ee20 (PR)
Upgrade the nodes to version: 87bf25c7a334caf8b93aa6412ce53021e284ee20
framework_upgrade::framework-upgrade::full-framework-upgrade : 6225 TPS, 6335 ms latency, 9700 ms p99 latency,no expired txns
5. check swarm health
Compatibility test for aptos-node-v1.3.0_3fc3d42b6cfe27460004f9a0326451bcda840a60 ==> 87bf25c7a334caf8b93aa6412ce53021e284ee20 passed
Test Ok

@larry-aptos larry-aptos merged commit ca2f498 into main May 18, 2023
@larry-aptos larry-aptos deleted the finalize-the-grpc-schema branch May 18, 2023 23:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants